Added cross-stream grouping to batches and nireqs in optimizer#779
Added cross-stream grouping to batches and nireqs in optimizer#779
Conversation
There was a problem hiding this comment.
in the grouping logic for both BatchGenerator and NireqGenerator
the if instance_id: checks might fail for empty string values, causing elements with the same empty instance_id to be ungrouped when they should share the same batch/nireq group.
upd: @walidbarakat corrected me right
LGTM then :)
walidbarakat
left a comment
There was a problem hiding this comment.
LGTM ...
@pbartosik a reminder please to spend few sentences to explain the decision and impact of change. that would save time and effort for reviewers
@oonyshch instance grouping happens only when user explicitly set model-instance-id to be the same value/id, otherwise - if model-instance-id is not set or set to null - OV will set automatically the instance id to be unique. in other words, each instance id is unique and each instance/stream is a group consists of one member .. unless the user specify otherwise.
Description
Please include a summary of the changes and the related issue. List any dependencies that are required for this change.
Fixes # (issue)
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: