Skip to content

Support for direct via routing#7105

Draft
optionsome wants to merge 4 commits intoopentripplanner:dev-2.xfrom
HSLdevcom:direct-via-routing
Draft

Support for direct via routing#7105
optionsome wants to merge 4 commits intoopentripplanner:dev-2.xfrom
HSLdevcom:direct-via-routing

Conversation

@optionsome
Copy link
Copy Markdown
Member

Summary

Adds support for direct routing when there are only via locations with coordinates specified in the request. If there are any via locations without coordinates (visit via locations with just stopLocations or pass-through via locations), direct routing is not executed.

This is currently based on #7090

Issue

Relates to #4887

Unit tests

TODO

Documentation

Not needed

Changelog

From title

@optionsome optionsome added the !New Feature A functional feature targeting the end user. label Dec 1, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 36.03604% with 142 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.22%. Comparing base (96ca627) to head (12951df).

Files with missing lines Patch % Lines
...oradapter/router/street/ViaDirectStreetRouter.java 0.00% 105 Missing ⚠️
.../opentripplanner/routing/impl/GraphPathFinder.java 54.54% 8 Missing and 2 partials ⚠️
...r/routing/algorithm/mapping/ItinerariesHelper.java 12.50% 7 Missing ⚠️
...aptoradapter/router/street/DirectStreetRouter.java 80.00% 3 Missing and 3 partials ⚠️
...src/main/java/org/opentripplanner/astar/AStar.java 0.00% 4 Missing ⚠️
...rg/opentripplanner/visualizer/GraphVisualizer.java 0.00% 3 Missing ⚠️
.../algorithm/mapping/GraphPathToItineraryMapper.java 94.11% 1 Missing and 1 partial ⚠️
...apter/router/street/DirectStreetRouterFactory.java 0.00% 1 Missing and 1 partial ⚠️
...tripplanner/street/search/StreetSearchBuilder.java 0.00% 2 Missing ⚠️
...apter/router/street/DefaultDirectStreetRouter.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #7105      +/-   ##
=============================================
- Coverage      71.29%   71.22%   -0.08%     
- Complexity     21217    21230      +13     
=============================================
  Files           2365     2368       +3     
  Lines          87770    87884     +114     
  Branches        8686     8689       +3     
=============================================
+ Hits           62574    62591      +17     
- Misses         22183    22280      +97     
  Partials        3013     3013              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!New Feature A functional feature targeting the end user.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants