Add stopsWithRegularTransfers build config parameter#7426
Draft
t2gran wants to merge 1 commit intoopentripplanner:dev-2.xfrom
Draft
Add stopsWithRegularTransfers build config parameter#7426t2gran wants to merge 1 commit intoopentripplanner:dev-2.xfrom
stopsWithRegularTransfers build config parameter#7426t2gran wants to merge 1 commit intoopentripplanner:dev-2.xfrom
Conversation
1a8d796 to
9ddf243
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7426 +/- ##
==========================================
Coverage 71.32% 71.33%
Complexity 21018 21018
==========================================
Files 2339 2339
Lines 86908 86928 +20
Branches 8605 8606 +1
==========================================
+ Hits 61991 62007 +16
- Misses 21919 21920 +1
- Partials 2998 3001 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Introduces a new build configuration parameter `stopsWithRegularTransfers` that allows operators to explicitly list stop IDs for which regular transfers are always pre-computed during graph build, even if the stop has no scheduled trips in the static data. This is needed for stops that are normally unused in static GTFS/NeTEx data but may be visited at runtime via real-time updates (e.g. a platform a train can be re-routed to). Without this, such stops are excluded from transfer pre-computation. The parameter is marked experimental and is intended as a temporary workaround until automatic transfer updates based on real-time updates are implemented.
9ddf243 to
5d40a8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a new (experimental) build configuration parameter
stopsWithRegularTransfersthatallows operators to explicitly list stop IDs for which regular transfers are always pre-computed
during graph build, even if those stops have no scheduled trips in the static data.
This is a targeted workaround for stops that are unused in static GTFS/NeTEx data but may be
visited at runtime via real-time updates (e.g. a platform a train can be re-routed to). Without
this, such stops are excluded from transfer pre-computation and become unreachable islands when a
real-time update routes a trip to them. The parameter is marked experimental and is intended
as a temporary measure until automatic transfer updates driven by real-time data are implemented.
Configuration
build-config.json{ "stopsWithRegularTransfers": ["RB:NSR:Quay:102541", "RB:NSR:Quay:209876"] }Documentation
doc/user/BuildConfiguration.mdupdated with the new parameter entry, description, andexperimental warning.
Breaking Changes
None. The new parameter is optional with an empty-list default; existing behaviour is unchanged.
Testing
Unit Tests
stopsWithRegularTransferspath not yet added — marked experimental.PatternNearbyStopFilterlogic change (removing the feature-flag guard onisSometimesUsedRealtime) is covered by the existing filter tests.Manual Testing
The feature has been tested manually and works.
Documentation
BuildConfiguration.mdChangelog
Should be included in the changelog as an experimental build-config addition.
Bumping the serialization version id
Note The
+Bump Serialization Idlabel should be set if this is merged, but due to some limitation in our CI/DI pipeline I will wait with this until we have decided to merge this - hopefully we are not merging this.