Add replacement mode filter to the GTFS API's planConnection query#7437
Merged
tkalvas merged 14 commits intoopentripplanner:dev-2.xfrom Apr 14, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7437 +/- ##
=============================================
- Coverage 71.32% 71.29% -0.04%
- Complexity 21018 21171 +153
=============================================
Files 2339 2360 +21
Lines 86908 87670 +762
Branches 8605 8681 +76
=============================================
+ Hits 61991 62507 +516
- Misses 21919 22145 +226
- Partials 2998 3018 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
We hope to have a feature to filter by intercity train / suburban train. Will this have any effect in the design? |
Contributor
Author
|
Jessica also wants filtering somewhat like that. I think these can be added easily, when we figure out how to map from netex submodes/extended gtfs types to the features we actually want to filter on, because the consensus was that we don't want to filter by them directly. |
optionsome
changed the title
optionsome
reviewed
Mar 24, 2026
optionsome
reviewed
Mar 26, 2026
Member
optionsome
left a comment
optionsome
left a comment
There was a problem hiding this comment.
You could also update some existing GraphQL integration test. I've forgotten the reason why we do the replacement mapping on the API side instead of when we construct the routes/trips. The filtering would probably be a bit more efficient if we stored the information about a trip/route being a replacement in their data structures.
|
|
||
| public MainAndSubMode toMainAndSubMode() { | ||
| if (this.replacement != null) { | ||
| throw new IllegalArgumentException("Not convertible to MainAndSubMode"); |
Member
There was a problem hiding this comment.
Not sure what is the correct exception here.
Contributor
Author
There was a problem hiding this comment.
Yeah, me neither. But I think we should check invariants and throw exceptions more.
optionsome
reviewed
Apr 9, 2026
optionsome
reviewed
Apr 10, 2026
optionsome
reviewed
Apr 10, 2026
optionsome
reviewed
Apr 12, 2026
optionsome
approved these changes
Apr 13, 2026
leonardehrenfried
approved these changes
Apr 13, 2026
optionsome
changed the title
optionsome
changed the title
t2gran
pushed a commit
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation to address issue #7270
Add boolean "replacement" to PlanTransitModePreferenceInput which makes it possible to select (for example) just the buses which are not replacements, or just the buses which are replacements, when filtering possible transit modes for planConnection.
I'm not that sure about the naming of NarrowedTransitMode, but couldn't come up with a good name. (I also intended it to have the explicit gtfs extended type lists, but that idea was discarded by an OTP dev meeting).
Unit tests
Had to adjust a couple of tests.
Unit test for the added functionality still missing, necessary for approval.
Documentation
No changes.
Changelog
Yes.
Bumping the serialization version id
No.