Remove GraphVisualizer and inefficient methods in ShortestPathTree#7526
Merged
leonardehrenfried merged 6 commits intoopentripplanner:dev-2.xfrom Apr 20, 2026
Merged
Conversation
leonardehrenfried
added
the
!Technical Debt
leonardehrenfried
force-pushed
the
remove-visualizer
branch
from
f339b01 to
1733f96
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7526 +/- ##
=============================================
+ Coverage 71.29% 72.54% +1.25%
+ Complexity 21214 21185 -29
=============================================
Files 2365 2357 -8
Lines 87754 86145 -1609
Branches 8681 8503 -178
=============================================
- Hits 62566 62498 -68
+ Misses 22178 20636 -1542
- Partials 3010 3011 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leonardehrenfried
force-pushed
the
remove-visualizer
branch
from
1733f96 to
8366f4d
Compare
# Conflicts: # application/src/main/java/org/opentripplanner/routing/impl/GraphPathFinder.java # application/src/main/java/org/opentripplanner/visualizer/GraphVisualizer.java # application/src/main/java/org/opentripplanner/visualizer/ShowGraph.java # application/src/test/java/org/opentripplanner/graph_builder/module/osm/OsmModuleTest.java
leonardehrenfried
force-pushed
the
remove-visualizer
branch
from
5ba864f to
16e3bff
Compare
vpaturet
requested changes
Apr 20, 2026
Contributor
vpaturet
left a comment
vpaturet
left a comment
There was a problem hiding this comment.
Looks good.
You can also remove onStartOptServerChkChanged()
leonardehrenfried
force-pushed
the
remove-visualizer
branch
from
007ef31 to
53b6236
Compare
vpaturet
approved these changes
Apr 20, 2026
tkalvas
approved these changes
Apr 20, 2026
t2gran
pushed a commit
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As dicussed today, this removes the
GraphVisualizerand also some methods inShortestPathTreethat eagerly createGraphPaths.