Introducing Batch Transfer (with helper functions for validations) #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is some extensive testing I wrote for this blueprint. https://gist.github.com/allquantor/122a6ea62cca19becbdc7ce5c7ac8c5f |
twilson63
reviewed
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
batch-transferaction to the token blueprint, providing feature parity with [PR #438](#438).However, unlike PR #438, this implementation extracts common logic—such as input validation and message replies—shared across
transfer,burn,mint, andbatch-transferinto reusable helper functions. This refactoring reduces overall complexity and improves readability.While this approach results in a "higher line count of changes" , the structural improvements aim to make the codebase more maintainable. Both PRs are presented for comparison, and I'm happy to open the floor to discuss which approach is preferred.