fix: avoid duplicate sharded directory scans#1229
fix: avoid duplicate sharded directory scans#1229jessejam wants to merge 1 commit intopromptfoo:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6c8dbdc9c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f6c8dbd to
ce976b1
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce976b1e19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ce976b1 to
0c49621
Compare
|
Thanks for the fix here. I verified the duplicate-scan issue is real and carried the change forward into #1231 so we could add one follow-up before merge: grouped shard families still need path-correct per-shard metadata/assets after deduping the scan work. Closing this in favor of the maintainer follow-up because this branch is not maintainer-editable. |
Summary
content_hashlimited to scan entries that actually ran when scans stop early.Validation
PROMPTFOO_DISABLE_TELEMETRY=1 ./.venv/bin/python -m pytest tests/test_core.py -k "sharded or content_hash_excludes"./.venv/bin/ruff format --check modelaudit/core.py tests/test_core.py./.venv/bin/ruff check modelaudit/core.py tests/test_core.py./.venv/bin/mypy modelaudit/core.py tests/test_core.pygit diff --checkNote: local validation used the existing project virtualenv because
uvis not installed in this environment.