DB + SNCB: remove E2E tests after endpoints permanently shut down#344
DB + SNCB: remove E2E tests after endpoints permanently shut down#344derhuerst merged 2 commits intopublic-transport:mainfrom
Conversation
|
I haven't looked into it closely, but hafas.bene-systems.com (cf #41) could actually be a viable replacement for some of that. |
04db4e0 to
f607960
Compare
|
Thanks for the hint! I looked into hafas.bene-system.com. The mgate.exe API exists but requires authentication: curl -s -X POST "https://hafas.bene-system.com/bin/mgate.exe" \
-H "Content-Type: application/json" \
-d '{"ver":"1.52","lang":"eng","auth":{"type":"AID","aid":"test"},"client":{"type":"AND"},"svcReqL":[{"meth":"ServerInfo","req":{}}]}' | jq '.err, .errTxt'
# Output: "AUTH", "HCI Core: Authorization fail"I think that until we resolve this, the SNCB tests should be disabled. |
Just FYI: There also is a |
test/e2e/db.js
Outdated
| @@ -1,3 +1,7 @@ | |||
| // Note: All tests in this file are skipped because the DB HAFAS endpoint | |||
There was a problem hiding this comment.
I think we can remove this file entirely. We can always obtain it from the Git history again if it turns out we need it.
There was a problem hiding this comment.
We can always obtain it from the Git history again if it turns out we need it.
Okay, I removed both of them right away - the same applies to SNCB.
f607960 to
e6cef0d
Compare
e6cef0d to
ff34a52
Compare
|
PTE seems to have support for it, which probably means that the key is baked into the Öffi app 👀 |
They seem to use https://hafas.bene-system.com/bin/stboard.exe (which doesn't need authorization). Unfortunately, that doesn't help us at the moment 🙁 |
I would like to reduce the number of failed tests. As a start, I suggest first deactivate the tests for both profiles - DB and SNCB.
Currently, 201 E2E tests are failing. After this change, there will be 25 fewer. I would look at the rest step by step.
Since the endpoints will most likely not return, we could alternatively remove them completely.
related: #284 and #306