Streamline .gitignore file#7992
Merged
pavoljuhas merged 11 commits intoquantumlib:mainfrom Apr 8, 2026
Merged
Conversation
Patterns like `.mypy_cache/*` did not match in subdirectories.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7992 +/- ##
==========================================
- Coverage 99.63% 99.63% -0.01%
==========================================
Files 1110 1110
Lines 99755 99755
==========================================
- Hits 99394 99393 -1
- Misses 361 362 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mhucka
requested review from
dstrain115 and
pavoljuhas
and removed request for
dstrain115
pavoljuhas
requested changes
Mar 31, 2026
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
Let us drop caches that already write their gitignore.
.gitignore
Outdated
| .pytest_cache/* | ||
| # ignore caches | ||
| .cache/ | ||
| .mypy_cache |
Collaborator
There was a problem hiding this comment.
For symmetry with others
NVM - let us remove mypy_cache completely.
Suggested change
| .mypy_cache | |
| .mypy_cache/ |
Contributor
Author
There was a problem hiding this comment.
The suggested edit in your last comment has .mypy_cache/, but your comment says to remove it. Is the suggested edit an accidental inclusion?
Pytest automatically creates a `.gitignore` file inside the `.pytest_cache` directory to prevent its contents from being tracked by Git; thus, a separate entry is not needed here. Ditto for Mypy and Ruff.
None of the dev tools used for Cirq seem to generate a .cache directory.
gitignore would be to handle temporary files that are from Python, unit tests, QA tools that we use, packaging and docs build files. Other files and directories that are produced by people's tools should be up to people to configure via editor settings or personal global .gitignores.
This is another thing that is not really a Cirq project item and should be put in a different place.
pavoljuhas
reviewed
Apr 8, 2026
pavoljuhas
approved these changes
Apr 8, 2026
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
Please put back the /out pattern. Otherwise LGTM.
mhucka
changed the title
.gitignore and add more patterns..gitignore file
pavoljuhas
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes some patterns that are either unnecessary or belong in a user's editor configurations.