Skip to content

Feature: Remove hardcoded index when selecting the correct build target #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature: Remove hardcoded index when selecting the correct build target #2707

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39fce6c
Fix: Remove hardcoded index when selecting the correct build target
jenskuhrjorgensen Aug 27, 2025
9f3831d
Fix: Update comment
jenskuhrjorgensen Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions packages/cli-platform-apple/src/commands/runCommand/getBuildSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,21 @@ export async function getBuildSettings(

const settings = JSON.parse(buildSettings);

const targets = settings.map(
({target: settingsTarget}: any) => settingsTarget,
);

let selectedTarget = targets[0];
// Find all 'app' targets in the build settings
const applicationTargets = settings
.filter(
(setting: any) =>
setting.buildSettings.WRAPPER_EXTENSION ===
'app',
)
.map(({target: settingsTarget}: any) => settingsTarget);

if (applicationTargets.length === 0) return null

let selectedTarget = applicationTargets[0];

if (target) {
if (!targets.includes(target)) {
if (!applicationTargets.includes(target)) {
logger.info(
`Target ${chalk.bold(target)} not found for scheme ${chalk.bold(
scheme,
Expand All @@ -53,18 +60,9 @@ export async function getBuildSettings(
selectedTarget = target;
}
}

// Find app in all building settings - look for WRAPPER_EXTENSION: 'app',
const targetIndex = targets.indexOf(selectedTarget);
const targetSettings = settings[targetIndex].buildSettings;

const wrapperExtension = targetSettings.WRAPPER_EXTENSION;

if (wrapperExtension === 'app') {
return settings[targetIndex].buildSettings;
}

return null;

const targetIndex = applicationTargets.indexOf(selectedTarget);
return settings[targetIndex].buildSettings;
}

function getPlatformName(buildOutput: string) {
Expand Down