Skip to content

feat(Echarts): allow option override children generation #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(Echarts): allow option override children generation #86

wants to merge 1 commit into from

Conversation

MarvelSQ
Copy link
Member

@MarvelSQ MarvelSQ commented Jul 12, 2023 •
edited
Loading

Feature

option should have the ability to overwrite the option generated by child components.

<MapChart option={{}}>
  <VisualMap .../>
</MapChart>

@vercel
Copy link

vercel bot commented Jul 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
charts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 7:31am

@MarvelSQ MarvelSQ requested a review from SevenOutman July 12, 2023 07:28
@SevenOutman
Copy link
Member

It's by-design that children takes precedence over option prop, which encourages user to use child components, and only use option prop as fallback when child component does not meet the requirement.

What do you think is the rationale that option prop should take precedence?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevenOutman SevenOutman Awaiting requested review from SevenOutman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarvelSQ @SevenOutman