-
Notifications
You must be signed in to change notification settings - Fork 176
Fix VSPipe arguments are not passed to VapourSynth script #1104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…guments Bump av-decoders from 0.3.1 to 0.4.0 Bump av-scenechange from 0.17.2 to 0.17.3
Bump av-decoders from 0.3.0 to 0.4.0
It appears there was never any support for VSPipe arguments when encoding the Target Quality probes. That has been fixed in the last commit. I consider that another reminder for us to consolidate encoding into a single class/function so we don't have to maintain 2 near-identical functions for encoding video. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1104 +/- ##
==========================================
+ Coverage 62.49% 62.54% +0.04%
==========================================
Files 23 23
Lines 6346 6370 +24
==========================================
+ Hits 3966 3984 +18
- Misses 2380 2386 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where VSPipe arguments were not being properly passed to VapourSynth scripts. The fix involves updating the API calls to pass arguments directly during decoder initialization rather than setting them separately after creation.
- Updates av-decoders to version 0.4.0 and av-scenechange to version 0.17.3
- Modifies VapourSynth decoder initialization to pass arguments in constructor
- Updates chunk creation methods to properly thread VSPipe arguments through the call chain
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
av1an-core/src/scene_detect.rs | Updates VapourSynth decoder creation to pass arguments in constructor |
av1an-core/src/context.rs | Refactors decoder creation and updates chunk generation to properly pass VSPipe arguments |
av1an-core/Cargo.toml | Bumps av-decoders to 0.4.0 and av-scenechange to 0.17.3 |
Co-authored-by: Copilot <[email protected]>
Fix unwrap used instead of expect in Target Quality simulation test
Resolves #1097
Bump av-decoders from 0.3.1 to 0.4.0
Bump av-scenechange from 0.17.2 to 0.17.3
These are predicted versions. If a different version is released I'll update the PR(s).Done.Requires both rust-av/av-decoders#4 and rust-av/av-scenechange#192 to be merged and released before merging this PR.Done and Cargo.lock updated, thanks.Thanks,
- Boats M.