Skip to content

Conversation

BoatsMcGee
Copy link
Collaborator

@BoatsMcGee BoatsMcGee commented Jul 30, 2025

Resolves #1097

Bump av-decoders from 0.3.1 to 0.4.0
Bump av-scenechange from 0.17.2 to 0.17.3

These are predicted versions. If a different version is released I'll update the PR(s). Done.

Requires both rust-av/av-decoders#4 and rust-av/av-scenechange#192 to be merged and released before merging this PR. Done and Cargo.lock updated, thanks.

Thanks,
- Boats M.

@BoatsMcGee
Copy link
Collaborator Author

It appears there was never any support for VSPipe arguments when encoding the Target Quality probes. That has been fixed in the last commit.

I consider that another reminder for us to consolidate encoding into a single class/function so we don't have to maintain 2 near-identical functions for encoding video.

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.54%. Comparing base (f65e23e) to head (147e56f).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
av1an-core/src/context.rs 83.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1104      +/-   ##
==========================================
+ Coverage   62.49%   62.54%   +0.04%     
==========================================
  Files          23       23              
  Lines        6346     6370      +24     
==========================================
+ Hits         3966     3984      +18     
- Misses       2380     2386       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shssoichiro shssoichiro requested a review from Copilot August 10, 2025 01:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where VSPipe arguments were not being properly passed to VapourSynth scripts. The fix involves updating the API calls to pass arguments directly during decoder initialization rather than setting them separately after creation.

  • Updates av-decoders to version 0.4.0 and av-scenechange to version 0.17.3
  • Modifies VapourSynth decoder initialization to pass arguments in constructor
  • Updates chunk creation methods to properly thread VSPipe arguments through the call chain

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
av1an-core/src/scene_detect.rs Updates VapourSynth decoder creation to pass arguments in constructor
av1an-core/src/context.rs Refactors decoder creation and updates chunk generation to properly pass VSPipe arguments
av1an-core/Cargo.toml Bumps av-decoders to 0.4.0 and av-scenechange to 0.17.3

@shssoichiro shssoichiro merged commit 1e612dc into rust-av:master Aug 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--vspipe-args not passed into vapoursynth script on subsequent runs
2 participants