disable detection of night latch for lock pro #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
requested changes
Aug 22, 2024
|
I added one test based on data from this PR discussion: #243 (comment) In this case adv parser nightlatch would be enabled, but he didn't have this feature turned on. |
bdraco
approved these changes
Aug 22, 2024
This was referenced Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should just disable this. It looks like night latch bit is not anymore in Lock Pro ADV.
Discussed in this draft: #245
For Home Assistant i create a little work around to force lock to be setup as if night latch is detected.
home-assistant/core#124326 (comment)
I don't believe OpenWonderLabs will publish documentation, which would help with correct implementation anytime soon.