-
Notifications
You must be signed in to change notification settings - Fork 54
Fix periodic reporting status for lock series #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
How does this work if the user only has passive scans on? |
If the user only has passive scanning, the user should not be able to add this device. |
Historically users turn on active scanning to add the device and than turn it back off once it's discovered. When active scans are on the connection times are much much longer |
If this is the case, there should be no problem. When the device is added, self.model is already determined. In subsequent scans, we only use the manufacturer_data in the advertisement. We don't need to know the service_data because we already know the type when the device is added.
|
@bdraco I have discussed this with our internal team and was told that different devices have different instructions for periodically reporting device status, so I made the following changes.
|
@bdraco Could you help to review this? |
Thanks for your patience! I'm currently awaiting battery delivery for proper testing of the lock functionality. Due to shipping restrictions on lithium-ion batteries to my location, delivery has been delayed, but tracking indicates arrival within 1-2 days. Once received, I'll thoroughly test the periodic reporting changes with actual hardware and merge if everything works as expected. I'll update this PR as soon as testing is complete. |
ok |
Batteries arrived, tested, everything seems ok with this change |
Uh oh!
There was an error while loading. Please reload this page.