Skip to content

Conversation

zerzhang
Copy link
Collaborator

@zerzhang zerzhang commented Aug 21, 2025

To fix issue : home-assistant/core#148558

For ceiling light, 0 is a valid color mode

After fix, The light value is displayed normally in ha

img_v3_02pc_4f772253-7526-4025-9dac-162ba7c8819g

Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
switchbot/devices/ceiling_light.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zerzhang zerzhang requested a review from bdraco August 21, 2025 09:41
@bdraco
Copy link
Member

bdraco commented Aug 21, 2025

Would you please add a test for this

@zerzhang
Copy link
Collaborator Author

Would you please add a test for this

Done

@bdraco bdraco merged commit 3f3a7a3 into sblibs:master Aug 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants