Add standardized feature set properties to Pcap++ target.#2136
Merged
Conversation
The feature set options follow the pattern `PCPP_HAS_XXX_SUPPORT`, with XXX being the target feature set. Currently if a feature set is active the cmake Pcap++ target will have a property with the corresponding name set to a truthy value and a corresponding compile time definition will be added to the compilation. This should allow consumers of the library to query the target at for features both at configure time and compile time.
Dimi1010
commented
May 10, 2026
|
|
||
| # Pcap++ Feature sets: | ||
| # - PCPP_HAS_PCAPNG_ZSTD_SUPPORT - Whether Pcap++ was built with support for zstd-compressed pcapng files using the light_pcapng library | ||
| # - PCPP_HAS_PCAP_FILE_SUPPORT - Whether Pcap++ was built with support for reading/writing pcap files (Pcap++ always has pcap file support) |
Collaborator
Author
There was a problem hiding this comment.
PCPP_HAS_PCAP_FILE_SUPPORT is for symmetry with PCPP_HAS_PCAP_LIVE_SUPPORT and PCPP_HAS_PCAP_REMOTE_SUPPORT.
Owner
There was a problem hiding this comment.
I don't think this is necessary. We should only export features which can be included or excluded
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2136 +/- ##
==========================================
- Coverage 82.66% 82.66% -0.01%
==========================================
Files 332 332
Lines 59736 59729 -7
Branches 12588 12590 +2
==========================================
- Hits 49379 49373 -6
- Misses 8953 8965 +12
+ Partials 1404 1391 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seladb
approved these changes
May 16, 2026
seladb
left a comment
seladb
left a comment
Owner
There was a problem hiding this comment.
Please see one comment, otherwise LGTM
|
|
||
| # Pcap++ Feature sets: | ||
| # - PCPP_HAS_PCAPNG_ZSTD_SUPPORT - Whether Pcap++ was built with support for zstd-compressed pcapng files using the light_pcapng library | ||
| # - PCPP_HAS_PCAP_FILE_SUPPORT - Whether Pcap++ was built with support for reading/writing pcap files (Pcap++ always has pcap file support) |
Owner
There was a problem hiding this comment.
I don't think this is necessary. We should only export features which can be included or excluded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #2129
The feature set options follow the pattern
PCPP_HAS_XXX_SUPPORT, with XXX being the target feature set. Currently if a feature set is active the cmake Pcap++ target will have a property with the corresponding name set to a truthy value and a corresponding compile time definition will be added to the compilation. Otherwise the target will have a false value on the property and no compile definition will be added to the compilation.This should allow consumers of the library to query the target at for features both at configure time and compile time.