Skip to content

Rename exawind applications to kynema#4838

Merged
psakievich merged 22 commits into
spack:developfrom
jrood-nrel:jrood/kynema1
Jun 15, 2026
Merged

Rename exawind applications to kynema#4838
psakievich merged 22 commits into
spack:developfrom
jrood-nrel:jrood/kynema1

Conversation

@jrood-nrel

Copy link
Copy Markdown
Member

A set of codes that had certain names, have been renamed to kynema to make them better.

@jrood-nrel jrood-nrel requested review from psakievich and removed request for faisal-bhuiyan May 13, 2026 21:57
@jrood-nrel

Copy link
Copy Markdown
Member Author

@spackbot fix style

@spackbot-app

spackbot-app Bot commented May 14, 2026

Copy link
Copy Markdown

Let me see if I can fix that for you!

@spackbot-app

spackbot-app Bot commented May 14, 2026

Copy link
Copy Markdown

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/kynema/package.py
repos/spack_repo/builtin/packages/kynema_driver/package.py
repos/spack_repo/builtin/packages/kynema_fmb/package.py
repos/spack_repo/builtin/packages/kynema_sgf/package.py
repos/spack_repo/builtin/packages/kynema_ugf/package.py
repos/spack_repo/builtin/packages/tioga/package.py
�[1;34m==> �[0mrunning ruff format
3 files reformatted, 3 files left unchanged
�[1;34m==> �[0mrunning ruff check
�[1m�[91mE501 �[0m�[1mLine too long (100 > 99)�[0m
   �[1m�[94m-->�[0m repos/spack_repo/builtin/packages/kynema_ugf/package.py:122:100
    �[1m�[94m|�[0m
�[1m�[94m120 |�[0m     conflicts(
�[1m�[94m121 |�[0m         "~hypre~trilinos-solvers",
�[1m�[94m122 |�[0m         msg="kynema-ugf: Must enable at least one of the linear-solvers: hypre or trilinos-solvers",
    �[1m�[94m|�[0m                                                                                                    �[1m�[91m^�[0m
�[1m�[94m123 |�[0m     )
�[1m�[94m124 |�[0m     conflicts(
    �[1m�[94m|�[0m

Found 2 errors (1 fixed, 1 remaining).
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@spackbot-triage spackbot-triage Bot requested a review from faisal-bhuiyan May 14, 2026 20:47
@spackbot-triage spackbot-triage Bot added the ci Issues related to Continuous Integration label May 18, 2026
@spackbot-triage spackbot-triage Bot requested a review from mwkrentel May 18, 2026 23:17
@spackbot-triage spackbot-triage Bot removed python ci Issues related to Continuous Integration labels May 18, 2026
@jrood-nrel jrood-nrel marked this pull request as draft June 2, 2026 17:46
@jrood-nrel jrood-nrel closed this Jun 2, 2026
@jrood-nrel jrood-nrel reopened this Jun 15, 2026
@jrood-nrel jrood-nrel marked this pull request as ready for review June 15, 2026 15:08

@ddement ddement left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. I went line-by-line in the new kynema-fmb package and that looks perfect.

@psakievich

Copy link
Copy Markdown
Contributor

Looks good to me. The mapping, while preserving the old packages looks like the right way to go. Out of curiosity, are you planning to remove the exawind packages later down the road?

@jrood-nrel

Copy link
Copy Markdown
Member Author

Thanks. I'm not sure if we will remove the old packages. Probably at some point further down the line.

@psakievich psakievich merged commit cee77bc into spack:develop Jun 15, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants