Rename exawind applications to kynema#4838
Merged
Merged
Conversation
* consistency with fmb variant * add forgotten option from PR spack#2270
Member
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/kynema/package.py
repos/spack_repo/builtin/packages/kynema_driver/package.py
repos/spack_repo/builtin/packages/kynema_fmb/package.py
repos/spack_repo/builtin/packages/kynema_sgf/package.py
repos/spack_repo/builtin/packages/kynema_ugf/package.py
repos/spack_repo/builtin/packages/tioga/package.py
�[1;34m==> �[0mrunning ruff format
3 files reformatted, 3 files left unchanged
�[1;34m==> �[0mrunning ruff check
�[1m�[91mE501 �[0m�[1mLine too long (100 > 99)�[0m
�[1m�[94m-->�[0m repos/spack_repo/builtin/packages/kynema_ugf/package.py:122:100
�[1m�[94m|�[0m
�[1m�[94m120 |�[0m conflicts(
�[1m�[94m121 |�[0m "~hypre~trilinos-solvers",
�[1m�[94m122 |�[0m msg="kynema-ugf: Must enable at least one of the linear-solvers: hypre or trilinos-solvers",
�[1m�[94m|�[0m �[1m�[91m^�[0m
�[1m�[94m123 |�[0m )
�[1m�[94m124 |�[0m conflicts(
�[1m�[94m|�[0m
Found 2 errors (1 fixed, 1 remaining).
I've updated the branch with style fixes. |
ddement
approved these changes
Jun 15, 2026
ddement
left a comment
Contributor
There was a problem hiding this comment.
Everything looks good to me. I went line-by-line in the new kynema-fmb package and that looks perfect.
psakievich
approved these changes
Jun 15, 2026
Contributor
|
Looks good to me. The mapping, while preserving the old packages looks like the right way to go. Out of curiosity, are you planning to remove the exawind packages later down the road? |
Member
Author
|
Thanks. I'm not sure if we will remove the old packages. Probably at some point further down the line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A set of codes that had certain names, have been renamed to
kynemato make them better.