openfoam: Add support for modules for openfoam@2512:#4868
Open
furstj wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds optional OpenFOAM “modules” subdirectories support in the Spack package, including new variant(s) and install-time inclusion of selected module sources.
Changes:
- Extend
submodules()to includemodules/adiosandmodules/visualizationbased on a newmodulesvariant selection. - Add a
modulesmulti-variant (conditional on@2512:) and add logic to installmodules/(andplugins/) sources when requested. - Introduce an
adios2variant (currently not integrated with the newmodulesselection).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| description="With optional modules", | ||
| values=("none", conditional("adios", "visualization", when="@2512:")), | ||
| multi=True, | ||
| ) |
adios2 is in dependencies as of openfoam@1912, so it seems to be not necessary anymore Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: