py-pyside6: add package for PySide6 (Qt for python)#4884
Draft
melven wants to merge 4 commits into
Draft
Conversation
Contributor
Author
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/py_pyside6/package.py
repos/spack_repo/builtin/packages/py_qtpy/package.py
�[1;34m==> �[0mrunning ruff format
1 file reformatted, 1 file left unchanged
�[1;34m==> �[0mrunning ruff check
�[1m�[91mE501 �[0m�[1mLine too long (100 > 99)�[0m
�[1m�[94m-->�[0m repos/spack_repo/builtin/packages/py_pyside6/package.py:44:100
�[1m�[94m|�[0m
�[1m�[94m42 |�[0m depends_on("py-mypy@1.15.0:", type="build")
�[1m�[94m43 |�[0m
�[1m�[94m44 |�[0m # can also build without opengl but generates warnings. network and accessibility seem required.
�[1m�[94m|�[0m �[1m�[91m^�[0m
�[1m�[94m45 |�[0m depends_on("qt-base@6.11: +network +accessibility +opengl")
�[1m�[94m46 |�[0m # can also build without tools but generates warnings...
�[1m�[94m|�[0m
�[1m�[91mE501 �[0m�[1mLine too long (103 > 99)�[0m
�[1m�[94m-->�[0m repos/spack_repo/builtin/packages/py_pyside6/package.py:56:100
�[1m�[94m|�[0m
�[1m�[94m54 |�[0m def patch(self):
�[1m�[94m55 |�[0m
�[1m�[94m56 |�[0m # shiboken include paths: misses non-qt-base paths (QtUiTools in qt-tools and Qt3D... in qt-3d)
�[1m�[94m|�[0m �[1m�[91m^^^^�[0m
�[1m�[94m57 |�[0m additional_includes = []
�[1m�[94m58 |�[0m if "+tools" in self.spec:
�[1m�[94m|�[0m
�[1m�[91mE501 �[0m�[1mLine too long (103 > 99)�[0m
�[1m�[94m-->�[0m repos/spack_repo/builtin/packages/py_pyside6/package.py:73:100
�[1m�[94m|�[0m
�[1m�[94m71 |�[0m filter_file(
�[1m�[94m72 |�[0m "pyside_build.update_rpath(executables)",
�[1m�[94m73 |�[0m "pyside_build.update_rpath(executables + pyside_build.package_libraries(destination_dir))",
�[1m�[94m|�[0m �[1m�[91m^^^^�[0m
�[1m�[94m74 |�[0m "build_scripts/platforms/unix.py",
�[1m�[94m75 |�[0m string=True,
�[1m�[94m|�[0m
Found 3 errors.
I've updated the branch with style fixes. |
Contributor
|
This partly duplicates #2877 where the package is added as a dependency. But the external json files there are non-standard and the version here is preferred. Not sure if you need addons and essentials too, but it could be an opportune time to add them in this PR as well (no pressure, not a review request). |
Contributor
Author
So the modules marked as essential during build are all there when compiling with I also made And I've added Now with Some are currently not enabled in And several others have no suitable qt-package in spack so far. But I won't manage to add / check all these ;) |
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/py_pyside6/package.py
repos/spack_repo/builtin/packages/py_qtpy/package.py
�[1;34m==> �[0mrunning ruff format
2 files left unchanged
�[1;34m==> �[0mrunning ruff check
�[1m�[91mE501 �[0m�[1mLine too long (103 > 99)�[0m
�[1m�[94m-->�[0m repos/spack_repo/builtin/packages/py_pyside6/package.py:60:100
�[1m�[94m|�[0m
�[1m�[94m58 |�[0m def patch(self):
�[1m�[94m59 |�[0m
�[1m�[94m60 |�[0m # shiboken include paths: misses non-qt-base paths (QtUiTools in qt-tools and Qt3D... in qt-3d)
�[1m�[94m|�[0m �[1m�[91m^^^^�[0m
�[1m�[94m61 |�[0m additional_includes = []
�[1m�[94m62 |�[0m if "+tools" in self.spec:
�[1m�[94m|�[0m
�[1m�[91mE501 �[0m�[1mLine too long (103 > 99)�[0m
�[1m�[94m-->�[0m repos/spack_repo/builtin/packages/py_pyside6/package.py:83:100
�[1m�[94m|�[0m
�[1m�[94m81 |�[0m filter_file(
�[1m�[94m82 |�[0m "pyside_build.update_rpath(executables)",
�[1m�[94m83 |�[0m "pyside_build.update_rpath(executables + pyside_build.package_libraries(destination_dir))",
�[1m�[94m|�[0m �[1m�[91m^^^^�[0m
�[1m�[94m84 |�[0m "build_scripts/platforms/unix.py",
�[1m�[94m85 |�[0m string=True,
�[1m�[94m|�[0m
Found 2 errors.
I wasn't able to make any further changes, but please see the message above for remaining issues you can fix locally! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.