Zsh: add build-time dependency on autoconf and add CFLAGS for more recent LLVM#4896
Open
taliaferro wants to merge 3 commits into
Open
Zsh: add build-time dependency on autoconf and add CFLAGS for more recent LLVM#4896taliaferro wants to merge 3 commits into
taliaferro wants to merge 3 commits into
Conversation
Contributor
Author
|
@spackbot fix style, if you'd be so kind |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/zsh/package.py
�[1;34m==> �[0mrunning ruff format
1 file reformatted
�[1;34m==> �[0mrunning ruff check
All checks passed!
�[1;34m==> �[0mstyle checks passed
I've updated the branch with style fixes. |
alalazo
requested changes
May 27, 2026
Comment on lines
+52
to
+56
| if ( | ||
| name == "cflags" | ||
| and self.spec.satisfies("%llvm@10:") | ||
| or self.spec.satisfies("%apple-clang@12:") | ||
| ): |
Member
There was a problem hiding this comment.
I think there's an issue with operator precedence here:
>>> False and False or True
True
(%apple-clang is always True regardless of name)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with zsh.
It seems zsh has a build-time dependency on autoconf. (It looks like it's re-running it later in the process and not finding it when it needs it)
Add two compiler flags (
-Wno-implicit-intand-Wno-implicit-function-declaration) when building with newer versions of LLVM.Without the latter, the build would complete successfully, but the resulting zsh would lock up and become unresponsive to signals the first time it encounters process substitution. (this issue can be demonstrated by running
timeout 3 zsh -c '$(echo echo success)' || echo failure.)