Editorial: Refactor SetNumberFormatDigitOptions for comprehensibility#1050
Open
Editorial: Refactor SetNumberFormatDigitOptions for comprehensibility#1050
Conversation
…d "max" rather than "mx"
…s "FD" and "SignificantDigits" as "SD"
…igitOptions reading `minimumIntegerDigits`
…edSD/needFD reassignment
sffc
reviewed
Apr 2, 2026
Contributor
sffc
left a comment
sffc
left a comment
There was a problem hiding this comment.
I agree that this is a pure refactor, no logic change.
I have a general preference for keeping the variable names the same; I don't see a reason to change them.
The main change here is to switch some if statements from
let variable be A
if B, then set variable to C
to
if B, let variable be C
else, let variable be A
This seems fine and probably beneficial.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompted by recent reviews of proposal-amount PRs.