Skip to content

✨ fix alpha order of terms, add script to detect problems and output all terms in alpha order#115

Open
ctcpip wants to merge 5 commits intomainfrom
alpha
Open

✨ fix alpha order of terms, add script to detect problems and output all terms in alpha order#115
ctcpip wants to merge 5 commits intomainfrom
alpha

Conversation

@ctcpip
Copy link
Copy Markdown
Member

@ctcpip ctcpip commented Jul 15, 2022

next step will be incorporating the alpha verification with a new github action for status checks

@ctcpip ctcpip requested review from ljharb and rkirsling July 15, 2022 18:25
Comment thread .editorconfig
Comment thread .eslintrc.js
@@ -0,0 +1,213 @@
module.exports = {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to hardcode everything here, instead of basing it on a popular common shared config?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just copying my boilerplate opinionated config. I'm fine with changing

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd personally prefer something minimal, and static, and largely based on something commonly used.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just don't bother. There's a bunch of scripts in ecma262 and those aren't linted. Since they're almost never touched it doesn't really matter.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's also a viable choice.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 nuked the rules block

Comment thread .vscode/settings.json Outdated
Comment thread package.json
Comment thread terminology.md
Comment on lines -154 to -158
## Web compatibility/"Don't break the web"

### Definition

A change to JavaScript is considered "**web compatible**" if it preserves the current behavior of existing websites. If it changes the behavior of existing websites, it's considered to "**break the web**".
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a) i think this diff should be done in a separate PR, and b) i'm not sure alphabetically is the best approach

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're not sorting the glossary, there's no reason to merge any of this

Comment thread verify-terminology-alpha.js
ctcpip and others added 2 commits July 15, 2022 14:02
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants