Skip to content

Conversation

fpseverino
Copy link
Member

@fpseverino fpseverino commented Sep 6, 2024

Issue #9

Originally authored by @compnerd in marmelroy#246

  • Add support for Windows
  • Add Windows CI tests
  • Drop support for Swift 5.8
  • Adopt swift-format
  • Add CI for iOS and MUSL
  • Various bug fixes

@fpseverino fpseverino added the enhancement New feature or request label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 98.17073% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.85%. Comparing base (567d515) to head (3078cbf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Zip/Zip.swift 97.41% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   96.07%   96.85%   +0.77%     
==========================================
  Files           7        8       +1     
  Lines         331      381      +50     
==========================================
+ Hits          318      369      +51     
+ Misses         13       12       -1     
Files with missing lines Coverage Δ
Sources/Zip/ArchiveFile.swift 100.00% <100.00%> (ø)
Sources/Zip/Date+dosDate.swift 100.00% <100.00%> (ø)
Sources/Zip/FileManager+ProcessedFilePath.swift 100.00% <100.00%> (ø)
Sources/Zip/QuickZip.swift 100.00% <100.00%> (ø)
Sources/Zip/URL+nativePath.swift 100.00% <100.00%> (ø)
Sources/Zip/ZipCompression.swift 100.00% <ø> (ø)
Sources/Zip/Zip.swift 94.82% <97.41%> (+1.46%) ⬆️

@fpseverino fpseverino marked this pull request as draft September 6, 2024 15:24
@fpseverino fpseverino linked an issue Sep 6, 2024 that may be closed by this pull request
@fpseverino fpseverino marked this pull request as ready for review September 7, 2024 16:37
@fpseverino fpseverino marked this pull request as draft September 7, 2024 17:39
@fpseverino fpseverino marked this pull request as ready for review September 8, 2024 21:48
@fpseverino fpseverino added the semver-minor Contains new API label Nov 5, 2024
@fpseverino fpseverino added semver-patch Internal changes only and removed semver-minor Contains new API labels Nov 5, 2024
Copy link

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of superfluous changes that make this difficult to review. Can you split out the changes to the doc comments into a separate change as a starting point?

@fpseverino
Copy link
Member Author

@compnerd I made a new PR with the changes related to Windows (in Zip.swift there are stil some unrelated changes that are hard to revert, I'm sorry)

@fpseverino fpseverino changed the title Windows support Windows support and other various changes Nov 6, 2024
@fpseverino fpseverino merged commit f38e9a9 into vapor-community:main Nov 7, 2024
15 checks passed
@fpseverino fpseverino deleted the windows branch November 7, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver-patch Internal changes only
Development

Successfully merging this pull request may close these issues.

Incorporate @compnerd's patch for Windows support
4 participants