This repository was archived by the owner on Dec 22, 2020. It is now read-only.
Open
Conversation
|
|
|
+1 on getting this merged |
2 similar comments
|
+1 on getting this merged |
|
+1 on getting this merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Developers use Webpack to bundle third party library into Service Workers hosted in Cloudflare Workers. This modification was made to allow bundling Mocha and a developer's unit tests into a Service Worker so they can be executed directly in the Cloudflare Workers runtime.
Mocha's implementation expects either the ability to import unit tests during runtime or file system access which is not available in Service Workers. This modification works around these limitations by importing test files at bundle time.
Breaking Changes
This PR does not introduce any breaking changes and should not impact any existing implementations.
Additional Info
N/A