feat: Add Domraem brand Ethernet clock pin configuration#5607
feat: Add Domraem brand Ethernet clock pin configuration#5607jacker-25 wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdds a new Ethernet board type "Domraem_ETH" by extending the board-type enum, adding it to the settings UI, and registering its hardware configuration in the ethernetBoards table. ChangesDomraem Ethernet Board Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai please check if the new ethernet config proposed in this PR is already covered by another existing configuration in network.cpp. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 12970
There is no functional difference between the two entries whatsoever. The PR author should verify whether the Domraem board's schematic genuinely matches the Gledopto wiring — if it does, the correct approach would be to either:
|
|
@coderabbitai please remember to perform the above check whenever a new ethernet configuration is proposed in a PR. The WLED policy for ethernet (classic esp32): we want to avoid duplicating table entries which are technically the same. If a new ethernet board is proposed and its more than a niche product, we prefer to extend the UI selection label. |
Add support for Domraem Ethernet board with clock pins (GPIO0).
This configuration allows WLED to work properly with ESP32 + Ethernet hardware from Domraem brand, avoiding conflicts between ESP-NOW and Ethernet clock signals.
Summary by CodeRabbit