fix: align rust signal hashing with JS helper#226
Conversation
Takaros999
requested review from
Gr1dlock,
Guardiola31337,
SeanROlszewski,
andy-t-wang,
murph and
paolodamico
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c720d1b494
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Takaros999
force-pushed
the
takis/fix-signal-hash-semantics
branch
from
c720d1b to
0f173e1
Compare
Takaros999
force-pushed
the
takis/fix-signal-hash-semantics
branch
from
0f173e1 to
ac5e035
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac5e035732
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Takaros999
force-pushed
the
takis/fix-signal-hash-semantics
branch
from
ac5e035 to
3f663f5
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
This PR fixes an issue with signal hashing.
0x...strings as bytes, which is a common use case for using wallet addresses as the signal.