Skip to content

fix(challenge): load challenges one by one from db to prevent oomkilled #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 3, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Aug 3, 2022

Changes

  • mark challenge as Cancelled if it is timeout by cct

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@cnlangzi cnlangzi marked this pull request as draft August 3, 2022 01:33
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #779 (6ec40b3) into staging (b0bcbb3) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           staging     #779      +/-   ##
===========================================
- Coverage    24.41%   24.40%   -0.01%     
===========================================
  Files           77       77              
  Lines         7826     7829       +3     
===========================================
  Hits          1911     1911              
- Misses        5648     5651       +3     
  Partials       267      267              
Flag Coverage Δ
Unit-Tests 24.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...de/go/0chain.net/blobbercore/writemarker/worker.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cnlangzi cnlangzi changed the title [WIP]chore(debug): disable challenge workers for debugging fix(challenge): load challenge one by one from db to prevent oomkilled Aug 3, 2022
@cnlangzi cnlangzi requested review from peterlimg, avanaur and ssardana08 and removed request for peterlimg and avanaur August 3, 2022 03:55
@cnlangzi cnlangzi marked this pull request as ready for review August 3, 2022 03:55
@cnlangzi cnlangzi requested a review from avanaur August 3, 2022 03:56
@cnlangzi cnlangzi changed the title fix(challenge): load challenge one by one from db to prevent oomkilled fix(challenge): load challenges one by one from db to prevent oomkilled Aug 3, 2022
@cnlangzi cnlangzi requested review from peterlimg and dabasov and removed request for avanaur August 3, 2022 08:06
@cnlangzi cnlangzi requested a review from ssardana08 August 3, 2022 11:01
Copy link
Contributor

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cnlangzi cnlangzi merged commit 9658eb1 into staging Aug 3, 2022
@cnlangzi cnlangzi deleted the fix/panicking_on_demo branch August 3, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants