Skip to content

hotfix #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2021
Merged

hotfix #80

merged 1 commit into from
Apr 18, 2021

Conversation

andrenerd
Copy link
Contributor

@andrenerd andrenerd commented Apr 18, 2021

@ronaudinho
Please, review and merge asap.
The issue prevents other PRs to be merged.

PS. What was wrong:

wallet, err := sigSch.GenerateKeys()

This call already generates all the keys for sigSch struct - public and private. And there were no need to make an extra call to set private key. That excessive call produces the error and it was removed.

@andrenerd andrenerd merged commit 4738447 into master Apr 18, 2021
@Sriep Sriep mentioned this pull request Apr 26, 2021
@platsko platsko deleted the blobber-fix-writemarker-tests branch May 9, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant