Directory tests #204
Directory tests #204
Conversation
|
these weren't failing initially - strange that they're failing now unless something has suddenly broken? |
|
@cnlangzi please don't merge this upon passing yet, I had moved some cases to |
|
@Kishan-Dhakan other related issues are raised on 0chain/blobber#590, 0chain/blobber#592 and 0chain/blobber#588 |
… into directory-tests
… into directory-tests
|
this looks ok to review again @Kishan-Dhakan @mohsenno1 right? |
|
@stewartie4 yep, OOMKilled issue is solved but almost every case is a FIXME. If it's not an issue, this should be ready to merge |
|
Maybe we should move these files to broken scenarios so we can better keep track on them |
|
where are we with this @mohsenno1? |
|
@stewartie4 I fixed the tests but directory operations are not working at the moment. I think this will be done after mainnet, see: https://0chain.slack.com/archives/C035RK9PTU0/p1652452527605049?thread_ts=1652443141.811229&cid=C035RK9PTU0. cc @cnlangzi please let us know whether coverage for directory operations is needed at the moment |
| allocationID := setupAllocation(t, configPath) | ||
| defer createAllocationTestTeardown(t, allocationID) | ||
|
|
||
| dirname := "/rootdir" |
There was a problem hiding this comment.
/rootdir is not root directory. / is.
|
@stewartie4 @Kishan-Dhakan Its better to raise issue and link respective system test PR and assign to somebody in the blobber/gosdk team. |
|
Yes. I would suggest to implement directory features/commands after mainnet. Because I think it is not good to implement it as a normal synchronous restful api |
|
@lpoli @cnlangzi @stewartie4 great, we're on the same page. |
|
Closing this, needs to be reopened post-mainnet. |
Re-open PR for dir-tests to investigate fails.