Quantity input - remove legend state #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove @legendapp/state imports and observer wrapper - Change $quantity Observable to quantity string + onQuantityChange callback - Change $invalidQuantity Observable to invalidQuantity boolean + onInvalidQuantityChange callback - Update component to use regular React props instead of .get()/.set() calls 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <[email protected]>
- Remove @legendapp/state imports and observable usage - Update all 13 test cases to use new props: quantity, invalidQuantity, onQuantityChange, onInvalidQuantityChange - Replace observable assertions with callback verification using vi.fn() - Maintain same test coverage and behavior validation 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <[email protected]>
- Replace @legendapp/state with React useState - Convert localQuantity$ and invalidQuantity$ observables to React state - Update QuantityInput usage to new props API - Maintain same functionality with standard React patterns 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <[email protected]>
- Add use$ import to bridge Legend State store with React props - Convert QuantityInput usage from $quantity/$invalidQuantity observables to props - Use use$() to extract values and callbacks to update store - Maintain existing store behavior while using new component API 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <[email protected]>
- Add use$ import to bridge Legend State store with React props - Convert QuantityInput usage from $quantity/$invalidQuantity observables to props - Use use$() to extract values and callbacks to update store - Maintain existing store behavior while using new component API 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <[email protected]>
- Replace observable import with use$ and useState - Convert local $invalidQuantity observable to React state - Bridge store $quantity with new QuantityInput props using use$() - Maintain existing store integration while using new component API 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <[email protected]>
- Remove QuantityInputBase.tsx as it's no longer needed after Legend State removal - Merge all functionality directly into QuantityInput component - Add useEffect to sync internal state with external prop changes - Eliminate unnecessary abstraction layer and simplify component structure 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <[email protected]>
- Add missing 'use client' directive to fix ESLint react-server-components/use-client error - Required because component passes function props (setInvalidQuantity) to child components 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.