Start passing in op-js user agent details #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdunnbirch
approved these changes
Jul 20, 2022
| import { default as open } from "open"; | ||
| import { window } from "vscode"; | ||
| import { version } from "../package.json"; |
There was a problem hiding this comment.
TIL you can import from package.json 🧑🎓
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1Password CLI will start collecting simple usage information via user agent. To support this op-vscode (by way of op-js) is going to specify a few environment variables for the CLI to pick up:
OP_INTEGRATION_NAME: "1Password for VS Code"OP_INTEGRATION_ID: "VSC"OP_INTEGRATION_BUILDNUMBER(numeric)It does this by calling the op-js helper
setClientInfoand passing this information in.