Skip to content

Conversation

jodyheavener
Copy link
Member

Closes #69

Users who use >= 2.6.2 of 1Password CLI with the extension are encountering errors when creating/saving an item.

This PR does the following:

  • Updates to v0.1.7 of op-js, which now correctly handles item creation before and after v2.6.2 of the CLI, where creation logic was modified.
  • Updates how we handle errors coming from the CLI. Specifically op-js now handles parsing the error response from CLI, so we don't need to.
  • Handles a couple other instances where a response value from a CLI command was undefined.

Co-authored-by: Mat Jones <[email protected]>
@jodyheavener jodyheavener merged commit e438924 into main Sep 27, 2022
@jodyheavener jodyheavener deleted the jh/more-error-handling branch October 26, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'reference')
2 participants