Add website translations #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carl <[email protected]>
Deploying 2fa with
|
| Latest commit: |
b103415
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://08013bfa.2fa.pages.dev |
| Branch Preview URL: | https://i18n.2fa.pages.dev |
hkamran80
reviewed
Nov 21, 2024
hkamran80
reviewed
Nov 21, 2024
hkamran80
reviewed
Dec 19, 2024
Member
hkamran80
left a comment
hkamran80
left a comment
There was a problem hiding this comment.
Were the icons intentionally made larger?
Member
Author
|
@hkamran80 No the size change of the icons was a mistake. Previously there was a padding of 9 pixels that I accidentally removed. Do you think it looks better with the padding? |
Member
Both look good. I like the larger icons. I was just wondering if it was intentional or not. |
Member
|
Is this ready to be merged? |
Member
Author
|
Yeah. The build works and I've verified the translations as best I can. |
hkamran80
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to serve translated versions of the site.
Also made the following UI changes:
The following translations have been verified to be correct: