Skip to content

[Backport release_3_10] Fix JS: Position and accuracy are undefined when Geolocation is stopped#6525

Merged
rldhont merged 3 commits intorelease_3_10from
backport-6523-to-release_3_10
Feb 3, 2026
Merged

[Backport release_3_10] Fix JS: Position and accuracy are undefined when Geolocation is stopped#6525
rldhont merged 3 commits intorelease_3_10from
backport-6523-to-release_3_10

Conversation

@3liz-bot
Copy link
Copy Markdown
Contributor

@3liz-bot 3liz-bot commented Feb 3, 2026

Backport #6523
Authored by: @rldhont

rldhont and others added 3 commits February 3, 2026 11:56
The OpenLayers Geolocation module keep the last position and accuracy when tracking is disabled.
For Lizmap Web CLient, when tracking is stopped, position and accuracy has to gat back to `undefined`
Creating playwright tests to check geolocation capabilities.
@github-actions github-actions bot added this to the 3.10.0 milestone Feb 3, 2026
@github-actions github-actions bot added tests unit tests and docker configuration for tests javascript Pull requests that update Javascript code labels Feb 3, 2026
@3liz-bot
Copy link
Copy Markdown
Contributor Author

3liz-bot commented Feb 3, 2026

All Playwright tests LEGACY

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
511 508 1 2 0 7 14m 10s

Failed Tests

Failed Tests ❌ Fail Message

Flaky Tests

Flaky Tests 🍂 Retries
WFS GetFeature townhalls_EPSG2154 for user_in_group_a 1
WFS GetFeature townhalls_EPSG2154 for admin 1
#2 Layer export with user_in_group_a user logged in 1
#5 Layer export with publisher user logged in 1
Popup with map click & attribute table 1
Catch GetLegendGraphic requests and timeout on GetLegendGraphic with multi layers 1
Switcher from map to map 1

Flaky Rate

Overall Flakiness 1.35%    ±0
Test 📝 Flaky Attempts 🍂 Total Attempts 🎯 Flaky Rate (%) 📈
WFS GetFeature townhalls_EPSG2154 for user_in_group_a 1 2 50.00    ↑50.00
WFS GetFeature townhalls_EPSG2154 for admin 1 2 50.00    ↑50.00
Catch GetLegendGraphic requests and timeout on GetLegendGraphic with multi layers 1 2 50.00    ↑50.00
Switcher from map to map 1 2 50.00    ↑50.00
#2 Layer export with user_in_group_a user logged in 1 3 33.33    ↑33.33
#5 Layer export with publisher user logged in 1 3 33.33    ↑33.33
#2 Layer export with user_in_group_a user logged in 1 3 33.33    ↑33.33
#5 Layer export with publisher user logged in 1 3 33.33    ↑33.33
Popup with map click & attribute table 1 4 25.00    ↑25.00
Popup with map click & attribute table 1 4 25.00    ↑25.00
Popup with map click & attribute table 1 4 25.00    ↑25.00

Github Test Reporter by CTRF 💚


All Playwright tests BLEEDING_EDGE

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
511 507 2 2 0 4 14m 45s

Failed Tests

Failed Tests ❌ Fail Message
❌ WFS GetFeature random_points Error: expect(received).toEqual(expected) // deep equality

Expected: 14
Received: 17

Flaky Tests

Flaky Tests 🍂 Retries
#2 Layer export with user_in_group_a user logged in 2
Manual play 1
Switcher from map to map 1
Build permalink, reload and apply one 1

Flaky Rate

Overall Flakiness 0.97%    ±0
Test 📝 Flaky Attempts 🍂 Total Attempts 🎯 Flaky Rate (%) 📈
#2 Layer export with user_in_group_a user logged in 2 4 50.00    ↑50.00
#2 Layer export with user_in_group_a user logged in 2 4 50.00    ↑50.00
Manual play 1 2 50.00    ↑50.00
Switcher from map to map 1 2 50.00    ↑50.00
Build permalink, reload and apply one 1 2 50.00    ↑50.00

Github Test Reporter by CTRF 💚

@rldhont rldhont merged commit 87d3aae into release_3_10 Feb 3, 2026
17 of 18 checks passed
@rldhont rldhont deleted the backport-6523-to-release_3_10 branch February 3, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code tests unit tests and docker configuration for tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants