Skip to content

Show rating at a glance and fix layout cutoff #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
5queezer merged 2 commits into from
Mar 19, 2026
Merged

Show rating at a glance and fix layout cutoff #81

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a8ee72
Show rating at a glance and fix Kanban/table right cutoff
5queezer Mar 19, 2026
50ea06c
Keep overflow-x-hidden on dashboard to prevent drag-induced page scroll
5queezer Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions components/application-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,14 @@ function MobileApplicationCard({ app, onEdit, onDelete, onArchive, showArchived
<div className="text-xs font-medium uppercase tracking-wide text-gray-400 dark:text-gray-500 mb-0.5">{t("source")}</div>
<div className="text-gray-700 dark:text-gray-300 break-words">{app.source || "—"}</div>
</div>
{app.rating && (
<div>
<div className="text-xs font-medium uppercase tracking-wide text-gray-400 dark:text-gray-500 mb-0.5">{t("rating")}</div>
<div className="text-yellow-400 text-sm tracking-tight" title={`${app.rating}/5`}>
{"★".repeat(app.rating)}{"☆".repeat(5 - app.rating)}
</div>
</div>
)}
</div>

{app.notes && (
Expand Down Expand Up @@ -221,6 +229,19 @@ export function ApplicationTable({ applications, onEdit, onDelete, onArchive, sh
cell: (info) => <StatusBadge status={info.getValue() as ApplicationStatus} />,
filterFn: "equals",
}),
columnHelper.accessor("rating", {
header: t("rating"),
cell: (info) => {
const r = info.getValue();
if (!r) return <span className="text-gray-400 dark:text-gray-500">—</span>;
return (
<span className="text-yellow-400 text-sm tracking-tight" title={`${r}/5`}>
{"★".repeat(r)}{"☆".repeat(5 - r)}
</span>
);
},
sortingFn: (a, b) => (a.original.rating ?? 0) - (b.original.rating ?? 0),
}),
columnHelper.accessor("source", {
header: t("source"),
cell: (info) => {
Expand Down Expand Up @@ -275,19 +296,6 @@ export function ApplicationTable({ applications, onEdit, onDelete, onArchive, sh
},
sortingFn: (a, b) => (a.original.salaryMin ?? 0) - (b.original.salaryMin ?? 0),
}),
columnHelper.accessor("rating", {
header: t("rating"),
cell: (info) => {
const r = info.getValue();
if (!r) return <span className="text-gray-400 dark:text-gray-500">—</span>;
return (
<span className="text-yellow-400 text-sm tracking-tight" title={`${r}/5`}>
{"★".repeat(r)}{"☆".repeat(5 - r)}
</span>
);
},
sortingFn: (a, b) => (a.original.rating ?? 0) - (b.original.rating ?? 0),
}),
columnHelper.display({
id: "contacts",
header: t("contacts"),
Expand Down
2 changes: 1 addition & 1 deletion components/dashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ export function Dashboard({ user, shareUrl }: DashboardProps) {
}

return (
<div className="min-h-screen bg-gray-50 dark:bg-gray-900 overflow-x-hidden">
<div className="min-h-screen bg-gray-50 dark:bg-gray-900">
Comment thread
5queezer marked this conversation as resolved.
Outdated
{/* Header */}
<header className="bg-white dark:bg-gray-800 border-b border-gray-200 dark:border-gray-700 sticky top-0 z-10">
<div className="max-w-7xl mx-auto px-4 sm:px-6 lg:px-8">
Expand Down
8 changes: 7 additions & 1 deletion components/kanban-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ function KanbanCard({ app, onEdit, isDragging = false }: CardProps) {
)}
</div>

{app.rating && (
<div className="mt-2 text-yellow-400 text-xs tracking-tight" title={`${app.rating}/5`}>
{"★".repeat(app.rating)}{"☆".repeat(5 - app.rating)}
</div>
)}

{app.notes && (
<div className="mt-2 max-h-10 overflow-hidden text-xs text-gray-500 dark:text-gray-400" title={app.notes}>
{app.notes}
Expand Down Expand Up @@ -273,7 +279,7 @@ export function KanbanView({ applications, onEdit }: KanbanViewProps) {
{STATUS_ORDER.map((status) => (
<div
key={status}
className="flex-none w-[260px] flex flex-col"
className="flex-1 min-w-[220px] flex flex-col"
>
<KanbanColumn
status={status}
Expand Down
Loading