Skip to content

[BUG] fix disable suggestion bug #3456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StevenACoffman merged 2 commits into from
Dec 25, 2024
Merged

[BUG] fix disable suggestion bug #3456

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df86df5
fix disable suggestion bug
tomoikey Dec 25, 2024
4366b32
use assert.Len
tomoikey Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions graphql/executor/executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,8 @@ func (e *Executor) parseQuery(
validator.RemoveRule("FieldsOnCorrectType")

rule := rules.FieldsOnCorrectTypeRuleWithoutSuggestions
// remove the rule added when it was last executed
validator.RemoveRule(rule.Name)
Comment on lines +230 to +231
Copy link
Copy Markdown
Collaborator Author

@tomoikey tomoikey Dec 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If gqlparser has a function like Contains, it might be better to use it and add a conditional if check to determine whether the rule is already duplicated.

However, in terms of computational cost, this implementation should not cause any issues. Therefore, I think it would be sufficient to leave this as a future TODO for now.

validator.AddRule(rule.Name, rule.RuleFunc)
}

Expand Down
7 changes: 7 additions & 0 deletions graphql/executor/executor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,14 @@ func TestExecutorDisableSuggestion(t *testing.T) {
exec.SetDisableSuggestion(true)
resp := query(exec, "", "{nam}")
assert.Equal(t, "", string(resp.Data))
assert.Equal(t, len(resp.Errors), 1)
assert.Equal(t, "input:1: Cannot query field \"nam\" on type \"Query\".\n", resp.Errors.Error())

// check if the error message is displayed correctly even if an error occurs multiple times
resp = query(exec, "", "{nam}")
assert.Equal(t, "", string(resp.Data))
assert.Equal(t, "input:1: Cannot query field \"nam\" on type \"Query\".\n", resp.Errors.Error())
assert.Equal(t, len(resp.Errors), 1)
})
}

Expand Down