Manage s3 policies#16
Merged
Merged
Conversation
mtibben
force-pushed
the
manage-s3-policies
branch
4 times, most recently
from
5a0d5fd to
567ccd5
Compare
mtibben
force-pushed
the
manage-s3-policies
branch
4 times, most recently
from
c20e61b to
cc7edee
Compare
Contributor
👍 |
Member
Author
|
OK, gonna bite the bullet and merge this. This does change the file layout, so I'll be bumping the major version to maintain semver. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #14, implements managing S3 bucket policies.
The file structure I ended up going with is
I was initially using option 2 as discussed in #14, but it looked a bit weird to my OCD brain seeing the directory listing like
Open to changing if anyone feels strongly ¯_(ツ)_/¯