Add support for skipping AWS service roles#53
Merged
Conversation
Creates a new single method that handles checking whether a resource should be skipped from managing as it is already managed via automated or alternative means.
AWS service roles aren't something that end users need to concern themselves with as they are managed by AWS and automatically applied to some services that require the interaction.
Closed
simpsora
approved these changes
Dec 11, 2018
simpsora
left a comment
simpsora
left a comment
There was a problem hiding this comment.
Looks excellent! Thanks @jacobbednarz.
|
This refactoring also should make it easier to implement a skip list (as suggested in #36). |
Collaborator
Author
|
Correct @simpsora. Once we yay/nay this approach, I'll open another PR with the additions. It will be relatively straight forward using a a newline delimited file for the custom ignores. |
Member
|
Looks good @jacobbednarz, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS service roles aren't something that end users need to concern
themselves with as they are managed by AWS and automatically applied to
some services that require the interaction.
To support this addition, I've refactored the skipping sections of the
existing functions to use a new method -
isSkippableManagedResource.This function consolidates the logic as to whether or not the resource
should be skipped.
Fixes #38