-
Notifications
You must be signed in to change notification settings - Fork 58
[WIP] Refactor: Tool now self-contained, BuildTime merged into it #198
Conversation
Also add building samples to GitHub Actions CI runs
Reason: 3.1 introduces ExcludeFromCodeCoverage on ThisAssembly, and the attribute is not available in net20 target from Attributes pkg.
|
@AArnott as seen in https://github.com/AArnott/CodeGeneration.Roslyn/runs/534972275#step:9:12 Nerdbank.GitVersioning v3.1 introduces ExcludeFromCodeCoverage on ThisAssembly, I had to downgrade. I know net20 is not supported, but maybe you could consider doing an exception for it like you did for netstandard1.x in dotnet/Nerdbank.GitVersioning#453 ? |
Don't require runtimes not provided by SDK version used.
|
I've updated the wiki for the newest changes: https://github.com/AArnott/CodeGeneration.Roslyn/wiki/Migrations |
|
@AArnott macos env in AzurePipelines times out since some time. Edit: |
|
@amis92 I see you already fixed the macOS problem. :) |

This is a major refactor.
It's triggered by a disaster of what 0.7.5-alpha turned out to be.
Major features:
dotnet-codegenpackage is nowCodeGeneration.Roslyn.Tool, as per project name.This was done to prevent confusion with previous CLI tool, which it now is not at all,
in terms of either DotNetCliToolReference-style tools and global/local .NET CLI tools.
Toolis now aDevelopmentDependency=truenormal Dependency package (as in,suitable for
PackageReferenceusage. Via various properties, it's setup so that it containsa framework-dependent executable (.dll) with all dependencies included. Using
build/CG.R.Tool.propsfile, the path to the executable is set in referencing projects.BuildTimepackage's props/targets were merged into theToolpackage because a separate package is no longer necessary, and as such necessary consumer dependencies are trimmed downto just
CodeGeneration.Roslyn.Toolpackage and a generator plugin of choice.TODO:
To use Sdk package as an Sdk element, the Sdk will need to be published to nuget.org, because MSBuildSdkResolver doesn't work well with local feeds.