-
Notifications
You must be signed in to change notification settings - Fork 48
Error with dataframes containing non-string column names #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
disregard the part about change the req for pandas. I don't know why my pandas version was stuck at 0.25.x in my test environment. I just realized that DABEST requires pandas v.1.1 now. |
Further tests showed that my initial fix was not working. I suggest testing for |
Solves issue #108 by converting all non-string color_groups to strings
Solves issue #108 by converting all non-string color_groups to strings
Solves issue #108 by converting all non-string color_groups to strings
Fix the bug #108 where non-string column names are supplied in DABEST usages by coordinating with the deprecation of providing only ‘palette’ with no ‘hue’
The bug is solved. |
Solved in PR #174. |
I've noticed DABEST does not let me work with dataframes where column names are not strings.
example:
results in an Exception:
As far as I understand, any hashable can be used as a column name (an
Index
really). I'm not sure what use case there is for exotic types, but I often have columns that are named withint
orfloat
.I'm going to propose a fix, but I'm not entirely sure the solution is robust. I'm would test for
Hashable
instead ofstr
, but some iterables are hashables (frozensets, tuples, range) and I don't quite know how you'd deal with that.PLUS there is an independent but related bug in pandas that prevents the fix from working. See here. The bug was fixed in v.1.0.0 and DABEST would need to require that version to work properly.
The text was updated successfully, but these errors were encountered: