Skip to content

Update Dockerfile to Absolute Path the Build Script #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CalebProvost opened this issue Apr 5, 2021 · 2 comments
Closed

Update Dockerfile to Absolute Path the Build Script #10

CalebProvost opened this issue Apr 5, 2021 · 2 comments
Assignees
@CalebProvost
Labels
complete
Milestone
Sprint 2

Comments

@CalebProvost
Copy link
Contributor

CalebProvost commented Apr 5, 2021 •
edited
Loading

As titled
DoD: Dockerfile will build L4T image regardless of where it is executed; does not need to be in the directory of the repo cloned.
@CalebProvost CalebProvost added the todo Work which needs to be done label Apr 5, 2021
@CalebProvost CalebProvost added this to the Sprint 2 milestone Apr 5, 2021
CalebProvost added a commit to cu-ecen-aeld/final-project-CalebProvost that referenced this issue Apr 11, 2021
@CalebProvost
Resolve issue: AESD-Course-Project/AESD-Course-Project.github.io#10
3ee2f32 
Signed-off-by: Caleb Provost <[email protected]>
@CalebProvost CalebProvost added WIP Current "work in progress" and removed todo Work which needs to be done labels Apr 11, 2021
@CalebProvost
Copy link
Contributor Author

@ZachTurner07,
Could you review if the latest push will work as you suggested?

@CalebProvost CalebProvost mentioned this issue Apr 12, 2021
Closed
@CalebProvost
Copy link
Contributor Author

CalebProvost commented Apr 12, 2021 •
edited
Loading

As per @ZachTurner07's comments, also adjusting docker container as to not contaminate the end-point build environment with that of the docker container's installations (allowing for re-builds of L4T without rebuilds of docker container).

Tested Changes: Builds and now doesn't pollute the build directory with docker installation junk.
Commit: https://github.com/cu-ecen-5013/final-project-CalebProvost/blob/dl4t/Dockerfile

CalebProvost added a commit to cu-ecen-aeld/final-project-CalebProvost that referenced this issue Apr 12, 2021
@CalebProvost
Resolve AESD-Course-Project/AESD-Course-Project.github.io#10
3879e64 
Signed-off-by: Caleb Provost <[email protected]>
CalebProvost added a commit to cu-ecen-aeld/final-project-CalebProvost that referenced this issue Apr 12, 2021
@CalebProvost
Resolve AESD-Course-Project/AESD-Course-Project.github.io#10
db0f717 
Signed-off-by: Caleb Provost <[email protected]>
@CalebProvost CalebProvost added complete and removed WIP Current "work in progress" labels Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CalebProvost CalebProvost

Labels
complete
Projects
None yet
Milestone
Sprint 2
Development

No branches or pull requests
1 participant
@CalebProvost