Fix exception in ray_worker #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FanhaiLu1
approved these changes
Jul 9, 2024
wang2yn84
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Fix exception in ray_worker * fix format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache manager recently added a parameter for env: https://github.com/google/jetstream-pytorch/blob/main/jetstream_pt/cache_manager.py#L94
But this is not passed in the Ray worker: https://github.com/google/jetstream-pytorch/blob/main/jetstream_pt/ray_worker.py#L353
This will cause the Ray process to crash when the cache manager tries to access self.env: https://github.com/google/jetstream-pytorch/blob/main/jetstream_pt/cache_manager.py#L106