Switch to Channel-based message processing#315
Merged
239573049 merged 3 commits intoAIDotNet:mainfrom Feb 13, 2026
Merged
Conversation
Replace manual SemaphoreSlim/task-list concurrency with a bounded Channel producer/consumer model. Adds System.Threading.Channels and a bounded channel (capacity 100, FullMode=Wait) as a shared buffer. Refactors ExecuteAsync to run a single producer that dequeues messages and writes to the channel, and MaxConcurrency consumer tasks that read from the channel and call ProcessMessageAsync. Completes the channel writer on shutdown and preserves message completion, retry and dead-letter handling. This simplifies concurrency control, provides backpressure, and cleans up task management and error handling.
Initialize the bounded Channel in the constructor with a capacity based on MaxConcurrency (Math.Max(1, MaxConcurrency) * 100) instead of a fixed 100. Preserve SingleWriter/SingleReader and FullMode settings. Also simplify task creation in ExecuteAsync by calling ProduceMessagesAsync and ConsumeMessagesAsync directly (removing unnecessary Task.Run wrappers) and awaiting them together with Task.WhenAll. These changes size the queue according to configured concurrency and reduce task scheduling overhead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace manual SemaphoreSlim/task-list concurrency with a bounded Channel producer/consumer model. Adds System.Threading.Channels and a bounded channel (capacity 100, FullMode=Wait) as a shared buffer. Refactors ExecuteAsync to run a single producer that dequeues messages and writes to the channel, and MaxConcurrency consumer tasks that read from the channel and call ProcessMessageAsync. Completes the channel writer on shutdown and preserves message completion, retry and dead-letter handling. This simplifies concurrency control, provides backpressure, and cleans up task management and error handling.