embed ring-based mempool #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leeopop 제가 사실 이 작업의 의의를 잘 파악하지 못해서 ㅜ 죄송합니다만 근홍님께서 판단하시고 실행해주시길 부탁드립니다. 그럼 간단히 리뷰하고 머지하겠습니다. |
|
링크가 되지 않는 코드 부분을 그대로 복붙해서 저희 코드에 넣었습니다. |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
@jeehoonkang 현재 상태가 최선인 듯 하여 이대로 머지하는게 좋겠습니다. #31 에 관련 내용 함께 적어두었습니다. |
|
bors r+ |
|
👎 Rejected by too few approved reviews |
|
@jeehoonkang 혹시 간단하게 리뷰 요청드려도 괜찮으실까요? |
|
제가 밖이라.. 리뷰 했습니다 머지해주세요 |
|
Build succeeded: |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
생각보다 매끄럽게 임배딩 되었습니다.
@jeehoonkang 이정도 속도면 자동으로 임배딩 하는 코드를 작성해볼까요?