Refactor export helpers into reusable node-export module#76
Closed
mniinio wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for apiops-cycles-canvascreator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
scripts/export.jsto a thin CLI wrapper.Description
src/node-export.cjsand moved non-CLI export logic there, includingbuildContent,buildFileName,renderSVG,writePDF,writePNG, and re-exportedexportJSONfromscripts/noteManager.scripts/export.jsto only parse CLI arguments and call the shared helpers from../src/node-export.cjs.package.jsonexportsas"./node-export": "./src/node-export.cjs"while keeping the existing root entry points intact.tests/export.test.jsto import the helpers fromsrc/node-export.cjsand validated the same exported API surface is available.Testing
npm test -- tests/export.test.jsand the test suite passed (all tests intests/export.test.jssucceeded).npm run buildand the build completed successfully.Codex Task