OsThreadNew is incorrectly limiting thread stack size to 64K

[david-oz00]

In the file cmsis_os2.c :

When the osThreadNew() function calls the FreeRTOS xTaskCreate() function it casts the stack size parameter to an (uint16_t) as seen below:

        #if (configSUPPORT_DYNAMIC_ALLOCATION == 1)
          if (xTaskCreate ((TaskFunction_t)func, name, (uint16_t)stack, argument, prio, &hTask) != pdPASS) {
            hTask = NULL;
          }

However, FreeRTOS allows the stack parameter to be defined by the user using configSTACK_DEPTH_TYPE. If the user defines the stack depth to be a uint32_t it could be truncated when cast to a uin16_t. I recommend the cast to be removed or at the very least, cast to configSTACK_DEPTH_TYPE like:

        #if (configSUPPORT_DYNAMIC_ALLOCATION == 1)
          if (xTaskCreate((TaskFunction_t)func, name, (configSTACK_DEPTH_TYPE)stack, argument, prio, &hTask) != pdPASS) {
            hTask = NULL;
          }
        #endif

[VladimirUmek]

Hi,
thanks for pointing this out. Since 64k of stack is enough for most application this was not an issue so far, but I agree that current implementation is limiting the stack incorrectly.

I'll push an update to cmsis_os2.c with implementation as you suggested.

[david-oz00]

Thanks Vladimir, we have a highly recursive algorithm requiring an especially large stack. I do agree it is an unusual scenario for embedded systems.