[aaelf64] Improve relocation optimizations [issue #328] #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve relocation optimizations to make the conditions clearer. Explain more explicitly explain that the Large GOT indirection optimization is all or nothing.
smithp35
reviewed
Jan 21, 2026
Contributor
smithp35
left a comment
smithp35
left a comment
There was a problem hiding this comment.
Overall looks good to me. I'm wondering if we want to avoid +-N in ranges to avoid the edge case of the range being exactly +N. AIUI it is -N <= range < N.
I've made a couple of suggestions to use the range of the relocation, that also lets us say which location the range is taken from.
Improve relocation optimizations to make the conditions clearer. Explain more explicitly that the Large GOT indirection optimization is all or nothing.
smithp35
approved these changes
Jan 21, 2026
Contributor
smithp35
left a comment
smithp35
left a comment
There was a problem hiding this comment.
Thanks for the update. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve relocation optimizations to make the conditions clearer. Explain more explicitly explain that the Large GOT indirection optimization is all or nothing.