Skip to content

Conversation

@stuij
Copy link
Member

@stuij stuij commented Jan 21, 2026

No description provided.

@stuij
Copy link
Member Author

stuij commented Jan 21, 2026

Hi @philgee-oss, could you have a look at this? Thanks!

.. |release| replace:: 2025Q1
.. |date-of-issue| replace:: 07\ :sup:`th` April 2025
.. |release| replace:: 2025Q4
.. |date-of-issue| replace:: 23\ :sup:`rd` January 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change 2025 to 2026 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ai, yea the release script didn't handle years being different from the year in the release name. Changed the script and updated the specs with the right year.

.. |date-of-issue| replace:: 07\ :sup:`th` April 2025
.. |release| replace:: 2025Q4
.. |date-of-issue| replace:: 23\ :sup:`rd` January 2025
.. |copyright-date| replace:: 2020-2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2020-2026 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

The release spec update script combined release year with release name. And so
when the release is outside of the release name year, we can't express
that. Updated the script to take split these by adding a release name argument
instead of a release quarter.
@philgee-oss
Copy link

LGTM

@stuij stuij merged commit ff38065 into main Jan 21, 2026
2 checks passed
@stuij stuij deleted the 2025q4-doc-prepare branch January 21, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants