Skip to content

Added README info for Serial Terminal #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

yennster
Copy link
Contributor

@yennster yennster commented Apr 3, 2018

This PR adds help information to the README file for the new Serial Terminal feature (#650)

It includes:

  • 2 usage examples for mbed compile and mbed detect
  • List of available keyboard shortcuts

@screamerbg

Copy link
Contributor

@sg- sg- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I'm not sure -s is right while we have -S

@@ -408,7 +408,8 @@ The arguments for *compile* are:
* `--config` to inspect the runtime compile configuration (see below).
* `-S` or `--supported` shows a matrix of the supported targets and toolchains.
* `-f` or `--flash` to flash/program a connected target after successful compile.
* `-c ` to build from scratch, a clean build or rebuild.
* `-s` or `--sterm` to open the connected target's serial terminal. This option can be chained with `-f` or `-r` so the new firmware image will be flashed to the target or reset, then open the serial terminal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-s and -S seem confusing. I get -fr for flash and reset but seems that ending in a terminal should be an explicit --sterm or better --terminal or --term

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would have to change the code than handles arguments to make that change. That's out of scope for this PR, probably.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't like using the word "terminal" here. It's a tad off, as it's specifically a hardware thing https://en.wikipedia.org/wiki/Computer_terminal . What were talking about is really a terminal emulator. We could also claim that daplink is the terminal, and that we are connecting to it, so --connect might also make sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theotherjimmy In terms of other tutorials (like the offline quickstart) we refer to viewing serial port output as opening up a "serial terminal". I personally think calling it an emulator is confusing. Thoughts? Maybe "serial port viewer"?

Copy link
Contributor

@theotherjimmy theotherjimmy Apr 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of how the word "terminal" is used these days, it probably means "something that takes input, accepts output and looks like a command line". That's why I mentioned that it was a personal pref. Also, calling it an "emulator" is confusing because you omit "terminal" and the user is left without the context of what is being emulated.


I think that "serial port viewer" may have the same problem that "sterm" and "serial terminal" has: it starts with an "s", making the short option -s, which conflicts with -S. Further, I would rather we use terminal here, as it's a better understood word for this than "port viewer", despite being slightly inaccurate. Especially as "port viewer" might imply to a user that they cannot interact with the device.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mbed terminal?

Note that mbed status is not a verb, nor is mbed releases

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well you have me there :D The -s vs -S conflict exists on mbed compile only, as far as I know. Are you suggesting that mbed term/mbed terminal builds the code too? Maybe through a switch? Maybe as opt-out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mbed monitor? 😆

Copy link

@kjbracey kjbracey Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "console" the word you're looking for? Regardless of what you have locally, and whether you call it a terminal or whatever you're looking and interfacing with the target's console.

(The word console got used in some of the new API added in mbed OS 5.8 to redirect stdin/stdout it to different physical interfaces).

Copy link
Contributor Author

@yennster yennster Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mbed console sounds good, but then the option -c would conflict with the existing -c for a clean build

@yennster
Copy link
Contributor Author

See revised PR #664

@screamerbg
Copy link
Contributor

@yennster The Serial Terminal functionality made it in the Mbed CLI 1.6 release. Do you think that this PR is still needed?

@yennster yennster closed this Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants