You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
User Authentication: Registration and login flow validation.
File Management: Full coverage for upload, download, delete, and restore functionality.
Permission Enforcement: Role-based access control (Admin vs. Member restrictions).
UI & Navigation: Basic route stability and page load verification.
Error Handling: Verification of 404 responses for invalid routes and data.
Lifecycle Flow: Integration testing covering the end-to-end user journey.
Type of change
Bug fix
New feature
Improvement / refactor
Documentation update
How to test
Ensure project dependencies are installed(pytest)
From the project root, run the entire test suite using the command pytest.
Verify that all test files in the tests directory execute and pass successfully.
Hey @reory — thank you for this contribution, really appreciate the effort here.
Review summary:
✅ Clean structure — conftest.py fixture with temp DB and monkeypatching is the correct approach
✅ Good coverage across all the areas asked for in #5 — auth, file lifecycle, permissions, error handling, and UI routes
✅ tests/__init__.py included — correct
✅ README testing section added with clear instructions
✅ PR is focused on one thing
One thing I fixed on our end before merging: pytest was missing from requirements.txt — I have added pytest==8.3.5 in a separate commit so new contributors can run pip install -r requirements.txt and be immediately ready.
Minor notes for future PRs (not blocking this one):
test_full_lifecycle.py hardcodes user_id=2 for Alice which assumes the admin was registered first as ID 1. This works for now but could be fragile if registration order changes — something to improve in a follow-up
Weak passwords like "246" in test data are fine for tests but worth using something slightly more realistic like "testpass123" for readability
Overall this is solid work and exactly what the project needed. Merging now. 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change
How to test
Ensure project dependencies are installed(
pytest)From the project root, run the entire test suite using the command
pytest.Verify that all test files in the
testsdirectory execute and pass successfully.Checklist
pytest